Fix GitHub Actions token authentication#248
Open
gmackie wants to merge 2 commits into
Open
Conversation
Accept tokens that fail OAuth app verification but pass /user endpoint.
This enables GitHub Actions tokens, PATs, and fine-grained PATs to work
for publishing packages.
When the /applications/{client_id}/token endpoint returns 404, the token
wasn't issued by our OAuth app but is still valid for GitHub API access.
We now accept these tokens since we already verified them with /user.
Also refactored auth module into auth/mod.rs + auth/tests.rs for better
organization and added unit tests for scope/org permission checks.
Security upgrade addressing CVE-2025-55182 (Critical RCE), CVE-2025-29927 (middleware auth bypass), CVE-2026-23864 (DoS), and CVE-2025-55183 (source exposure). Also upgrades React, eslint-config-next, and related @next/* packages where needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #238 - GitHub Actions tokens now work for publishing packages.
Problem
When using
wally publishwith GitHub Actions tokens (or PATs/fine-grained PATs), the registry returned:This happened because the
/applications/{client_id}/tokenendpoint returns 404 for tokens not issued by the OAuth app, even though they're valid GitHub tokens.Solution
/userendpointChanges
auth/mod.rs+auth/tests.rsfor better organizationTesting