Fix errors when writing to backup file from different processes #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drowze
commented
Sep 17, 2025
|
|
||
| # NOTE: this is a frequent issue with Puma (in clustered mode). See Unleash/unleash-ruby-sdk#108 | ||
| it "does not log errors due to concurrent forked processes" do | ||
| log_file = ->(pid) { File.join(Dir.tmpdir, "#{pid}.log") } |
There was a problem hiding this comment.
NOTE: getting the stdout/stderr from child processes is tricky so the temporary log file here is just a dirty way to capture the child process logger output.
Drowze
force-pushed
the
fix-writing-to-backup-file
branch
2 times, most recently
from
705c134 to
72cbf06
Compare
Drowze
force-pushed
the
fix-writing-to-backup-file
branch
from
72cbf06 to
2bc2ca1
Compare
Pull Request Test Coverage Report for Build 17807791681Details
💛 - Coveralls |
gastonfournier
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Prevent errors when attempting to move the temporary backup_file while using Unleash in forked processes (e.g.: Puma clustered mode)
Closes #108
Important files
Discussion points