feat: read backup file and bootstrap for streaming #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17298764007Details
💛 - Coveralls |
kwasniew
commented
Aug 28, 2025
| require 'json' | ||
|
|
||
| module Unleash | ||
| class BackupFileReader |
There was a problem hiding this comment.
this is extracted from toggle_fetcher
kwasniew
commented
Aug 28, 2025
| self.event_processor = Unleash::StreamingEventProcessor.new(engine) | ||
| self.running = false | ||
|
|
||
| begin |
There was a problem hiding this comment.
similar setup to toggle fetcher in polling mode but we don't make first request to the server and instead go straight to either bootstrap or a backup file. Then streaming starts and takes over from there
sighphyre
approved these changes
Sep 3, 2025
lib/unleash/backup_file_reader.rb
Outdated
| Unleash.logger.error "Unable to read the backup_file: #{e}" | ||
| # :nocov: | ||
| nil | ||
| rescue JSON::ParserError => e |
There was a problem hiding this comment.
I actually don't think this case can happen since we no longer parse on read. I realise this is a hangover from the old implementation (my bad, should have dropped this when I ported to Ygg). If we don't remove it in this PR, no biggie, I'll do it in a future one
| read_backup_file!(engine) | ||
| end | ||
| rescue StandardError => e | ||
| # fail back to reading the backup file |
There was a problem hiding this comment.
Also a hangover from the old code haha, but may as well fix it while we're here
Suggested change
| # fail back to reading the backup file | |
| # fall back to reading the backup file |
| require 'json' | ||
|
|
||
| module Unleash | ||
| class BackupFileReader |
github-project-automation
bot
moved this from In Progress
to Approved PRs
in Issues and PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points
We may consider reading backup file outside of the fetcher/streamer if we change current architecture a bit