Conversation
…able (#51) Merges fulfil_contact_metadata, fulfil_broker_contacts, and fulfil_uncategorized_contacts into a unified fulfil_contacts table with type and source columns to preserve semantics. Replaces three near-identical models with a single FulfilContact model using query scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #51
fulfil_contact_metadata,fulfil_broker_contacts, andfulfil_uncategorized_contactsinto a singlefulfil_contactstable withtypeandsourcecolumns to preserve semantic distinctionsFulfilContactmodel using query scopes (broker(),discovered(),uncategorized(), etc.)Motivation
All three tables had nearly identical schemas (same
fulfil_party_id,email,last_emailed_at,last_received_at) and duplicate model logic (recordEmailSent,recordEmailReceived). GmailService had to query across all three to build a full contact picture. This consolidation simplifies queries, eliminates code duplication, and makes the contact model easier to extend.Migration notes
fulfil_contacts, then drops themINSERT IGNORE(MySQL) /INSERT OR IGNORE(SQLite) to handle any duplicate(fulfil_party_id, email)pairs across the old tablesdown()migration reverses the process if neededTest plan
fulfil_contact_metadata, plus broker and uncategorized contacts)