fix!: rename variant.selected_options → options#353
Merged
Conversation
Completes a rename decided in PR #195 (get_product operation) but never executed on variant.json. The get_product operation introduced three distinct concepts that were previously conflated: request.selected — what the user chose (input parameter) product.selected — what the server resolved (response, post-relaxation) variant.options — what the variant IS (intrinsic, immutable) A variant's option values (Color: Blue, Size: Large) are intrinsic identity — they don't change based on user selections or server relaxation. The old name "selected_options" implied a relationship to user selection state that doesn't exist at the variant level. Schema: variant.selected_options → variant.options Docs: update variant examples in mcp.md and rest.md
koenbouwmans
approved these changes
Apr 10, 2026
jingyli
approved these changes
Apr 10, 2026
raginpirate
approved these changes
Apr 11, 2026
ihoosain
approved these changes
Apr 11, 2026
richmolj
approved these changes
Apr 11, 2026
jingyli
pushed a commit
to jingyli/ucp
that referenced
this pull request
Apr 13, 2026
…l#353) Completes a rename decided in PR Universal-Commerce-Protocol#195 (get_product operation) but never executed on variant.json. The get_product operation introduced three distinct concepts that were previously conflated: request.selected — what the user chose (input parameter) product.selected — what the server resolved (response, post-relaxation) variant.options — what the variant IS (intrinsic, immutable) A variant's option values (Color: Blue, Size: Large) are intrinsic identity — they don't change based on user selections or server relaxation. The old name "selected_options" implied a relationship to user selection state that doesn't exist at the variant level. Schema: variant.selected_options → variant.options Docs: update variant examples in mcp.md and rest.md
12 tasks
jingyli
added a commit
that referenced
this pull request
Apr 13, 2026
Completes a rename decided in PR #195 (get_product operation) but never executed on variant.json. The get_product operation introduced three distinct concepts that were previously conflated: request.selected — what the user chose (input parameter) product.selected — what the server resolved (response, post-relaxation) variant.options — what the variant IS (intrinsic, immutable) A variant's option values (Color: Blue, Size: Large) are intrinsic identity — they don't change based on user selections or server relaxation. The old name "selected_options" implied a relationship to user selection state that doesn't exist at the variant level. Schema: variant.selected_options → variant.options Docs: update variant examples in mcp.md and rest.md Co-authored-by: Ilya Grigorik <ilya@grigorik.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #195 described the change and intent but commit got lost between working and merged branch (doh!). This PR lands the change described in 195. This is a breaking change relative to current schema:
variant.selected_options→variant.options. With this change in place, we have:request.selected— what the user chose (input parameter)product.selected— what the server resolved (response, post-relaxation)variant.options— what the variant IS (intrinsic, immutable)Checklist