docs: omit deprecated checkout id from playground payload#332
Open
gaureshpai wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
docs: omit deprecated checkout id from playground payload#332gaureshpai wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
gaureshpai wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
gaureshpai
force-pushed
the
fix/playground-deprecated-id
branch
2 times, most recently
from
5a4bacd to
5ccf830
Compare
gaureshpai
force-pushed
the
fix/playground-deprecated-id
branch
2 times, most recently
from
1eeaa6a to
4700210
Compare
Removes checkoutResponse.id from the update payload in playground.md. This field is marked as deprecated_required_to_omit for update requests (as the ID is now passed in the URL path). It was previously only commented as deprecated without actually removing the property from the payload object.
gaureshpai
force-pushed
the
fix/playground-deprecated-id
branch
from
4700210 to
b35f926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While reviewing the interactive playground script in
docs/specification/playground.md, I noticed that theidproperty was still being passed inside thepatchobject for update requests. Since this field was recently marked asdeprecated_required_to_omit(as it is provided via the URL path), the playground was inadvertently generating non-compliant payloads. This PR fixes the playground payload creation by properly initializing an empty patch object.Type of change
Please delete options that are not relevant.
Checklist
Pull Request Title
docs: omit deprecated checkout id from playground payload