fix: networkanimator does no bounds check when reading parameters#4090
Merged
NoelStephensUnity merged 6 commits intoJul 16, 2026
Merged
Conversation
NoelStephensUnity
changed the title
…/github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/UUM-147271-networkanimator-bounds-check
NoelStephensUnity
marked this pull request as ready for review
July 16, 2026 16:56
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4090 +/- ##
=================================================
+ Coverage 66.39% 66.40% +0.01%
=================================================
Files 163 163
Lines 24999 24999
=================================================
+ Hits 16597 16601 +4
+ Misses 8402 8398 -4
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes
|
NoelStephensUnity
deleted the
fix/UUM-147271-networkanimator-bounds-check
branch
July 16, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
NetworkAnimatorcan cause an exception and/or crash if a parameter update is received with an invalid parameter index value.Jira ticket
UUM-147271
Changelog
NetworkAnimatordid no bounds check on the parameter index read prior to obtaining a pointer to the location within the array.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsNetworkAnimatorTests.ParameterBoundsCheckDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No back port is required.
Up-port
This fix will be included in the last full merge after the v2.13.1 update.