Skip to content

Conversation

@MiroBrodlovaUnityGit
Copy link
Collaborator

Please read and consider what information you want to pass on to people reviewing this PR

Purpose of PR

Type of change:

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

This PR replaces all instances of Mono API calls with CoreCLR-compatible API calls in this repo, and is part of Epic SCP-1555.

Note:
More PRs dealing with SCP-1555 may come in the future. In some cases we cannot replace all Mono API calls with CoreCLR API calls yet, as some CoreCLR APIs are still being worked on/are not yet public (see for example SCP-1542, and SCP-1544). In these cases we suppress warnings for those particular APIs for now. Later on, once the equivalent CoreCLR APIs are made public, we will do a second pass across all packages and replace the suppressed warning/old API with the new public CoreCLR API instead.

Description of the feature

  • Unity is steadily moving away from Mono to using CoreCLR.
  • With this we need to replace all Mono API calls with CoreCLR-compatible ones. (here's the list of APIs being replaced, and here's the list of packages that will get updated).
  • Epic SCP-1555 tracks the work of replacing all Mono API calls across all Unity supported packages with CoreCLR-compatible ones. This PR is part of that epic.
  • For more information, or if you have any questions, please visit #code-reload-safe-api-packages-migration and we'll be happy to help. 🙂
  • Links to Jira/Fogbugz cases
    https://jira.unity3d.com/browse/SCP-1572
  • Performance Impact
    Shouldn't have significant impact on performance as the new API should be equivalent performant-wise.
  • Package requirements
    These new APIs are only available in Unity 6000.5 and up.

Checklist for PR maker

  • Have you added a backport label? (if needed)
  • Have you updated the Changelog? Each package has a CHANGELOG.md file
  • Have you added or updated the Documentation to your PR? When you add a new feature, change a property name, or change the behaviour of a feature, it's best practice to include related documentation changes in the same PR

I haven't done any of these, but if they should be done do tell me and I'll look at them too!

Testing status

Running the default job-suite that is run on new PRs. Please do share if there's some steps I've missed that I must do to properly setup the PR and run your CI jobs!

  • Testing checklist
  • Built and run editor Locally or Katana
  • Built a player Android/iOS (if applicable)
  • Run on device Android/iOS (if applicable)
  • If new feature has UI, does it match Unity style? (Unity HIG?)
  • Tested Undo/Redo + Prefab overrides + Alignment in Preset
  • All items have tooltips?

Comments to reviewers

If there are any jobs/tests we should run to make sure there are no ripple effects do share and we will kick them off! :) And, if you know of any locations we may have missed updating or any details that we should know about, please do share!

@todi1856
Copy link
Member

Could you also add an entry under 1.4.7 - https://github.com/MiroBrodlovaUnityGit/com.unity.mobile.logcat/blob/master/com.unity.mobile.android-logcat/CHANGELOG.md ?

Copy link
Member

@todi1856 todi1856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remake PR in main repo, since Yamato tests are not running in fork

@MiroBrodlovaUnityGit
Copy link
Collaborator Author

Can you remake PR in main repo, since Yamato tests are not running in fork

Yes, for sure! As soon as I have time (just on a few other things first) I will try making one in the main repo instead of a fork :) and will add a changelog too (thanks for the heads up on this)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants