Update Mono API calls to CoreCLR-compatible API calls #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and consider what information you want to pass on to people reviewing this PR
Purpose of PR
Type of change:
This PR replaces all instances of
MonoAPI calls withCoreCLR-compatible API calls in this repo, and is part of Epic SCP-1555.Note:
More PRs dealing with SCP-1555 may come in the future. In some cases we cannot replace all
MonoAPI calls withCoreCLRAPI calls yet, as someCoreCLRAPIs are still being worked on/are not yet public (see for example SCP-1542, and SCP-1544). In these cases we suppress warnings for those particular APIs for now. Later on, once the equivalentCoreCLRAPIs are made public, we will do a second pass across all packages and replace the suppressed warning/old API with the new publicCoreCLRAPI instead.Description of the feature
Monoto usingCoreCLR.MonoAPI calls withCoreCLR-compatible ones. (here's the list of APIs being replaced, and here's the list of packages that will get updated).MonoAPI calls across all Unity supported packages withCoreCLR-compatible ones. This PR is part of that epic.https://jira.unity3d.com/browse/SCP-1572
Shouldn't have significant impact on performance as the new API should be equivalent performant-wise.
These new APIs are only available in Unity 6000.5 and up.
Checklist for PR maker
CHANGELOG.mdfileI haven't done any of these, but if they should be done do tell me and I'll look at them too!
Testing status
Running the default job-suite that is run on new PRs. Please do share if there's some steps I've missed that I must do to properly setup the PR and run your CI jobs!
Comments to reviewers
If there are any jobs/tests we should run to make sure there are no ripple effects do share and we will kick them off! :) And, if you know of any locations we may have missed updating or any details that we should know about, please do share!