Skip to content

[editor] Handle selection history in Shader Graph and VFX Graph (WIP) #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aras-p
Copy link
Contributor

@aras-p aras-p commented Jan 9, 2022

Purpose of this PR

I'm implementing "selection history" for the editor as a whole, and while it handles "things that participate in Selection C# API" (game objects & assets) out of the box, the shader & vfx graph selections are neither assets nor game objects. So this implements support for selection history for these graph views, so that the new back/forward buttons would work nicely as a user would expect them to.

This will require https://github.cds.internal.unity3d.com/unity/unity/pull/7194 to land first in the "main" editor codebase, and as such this PR is WIP/draft for now.

Testing status

TBD

Comments to reviewers

TBD

@github-actions
Copy link

github-actions bot commented Jan 9, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@aras-p aras-p force-pushed the feature/selection-history branch from 2716b28 to a8889d1 Compare January 11, 2022 07:31
@julienf-unity
Copy link
Contributor

Not sure what's the status of this PR now that Aras left?

@julienf-unity
Copy link
Contributor

@julienamsellem Is it something that we should consider merging?

@aras-p
Copy link
Contributor Author

aras-p commented Feb 17, 2022

@julienf-unity this PR first needs the unity main codebase side PR (that adds newly needed Selection APIs) to land first. I don't know if it landed yet :) But, talk with Marius Zrelskis on Slack -- I've left up to him to land both the code side PR, and this one.

@julienamsellem
Copy link
Contributor

This PR is depends on another PR on the editor which is not merged yet. So until this dependency is merged we cannot merge.
But at least we can test it and see if it works fine with latest changes.

@julienf-unity
Copy link
Contributor

Ok just wanted to make sure this wasnt some work for nothing. Looks like this PR will have to be migrated for srp2core2 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants