Skip to content

[Hold] Add dark light theme icons with zoom #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[Hold] Add dark light theme icons with zoom #6510

wants to merge 2 commits into from
+641 −125

Conversation

skhiat
Copy link
Contributor

@skhiat skhiat commented Dec 7, 2021 •
edited
Loading

@github-actions github-actions bot added the SRP label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@skhiat skhiat changed the title [hold] Clean up lens flare icons [hold] Had dark light theme icons with zoom Dec 7, 2021
@skhiat skhiat requested a review from RSlysz December 7, 2021 11:43
RSlysz
RSlysz approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@RSlysz RSlysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@skhiat skhiat changed the title [hold] Had dark light theme icons with zoom Had dark light theme icons with zoom Jan 11, 2022
@skhiat skhiat changed the title Had dark light theme icons with zoom [Hold] Had dark light theme icons with zoom Jan 11, 2022
@skhiat skhiat changed the title [Hold] Had dark light theme icons with zoom [Hold] Add dark light theme icons with zoom Jan 12, 2022
@sebastienlagarde
Copy link
Contributor

bump

@skhiat
Copy link
Contributor Author

skhiat commented Jan 13, 2022

Icon color fixed but we still have a bug on zoom:
https://fogbugz.unity3d.com/f/cases/1394399/
(updated description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSlysz RSlysz RSlysz approved these changes

Assignees

@kecho kecho

Labels
SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skhiat @sebastienlagarde @RSlysz @kecho