Skip to content

Transform Node Screen Space only #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Transform Node Screen Space only #6467

wants to merge 27 commits into from
+11,476 −101

Conversation

skhiat
Copy link
Contributor

@skhiat skhiat commented Dec 2, 2021 •
edited
Loading

Note: already reviewed [PR - splitting ShaderGraph only code]
image

Add ClipSpace for TransformNode:
image

image

UX review notes: changes the order of parameters

https://jira.unity3d.com/browse/HDRP-1600
https://jira.unity3d.com/browse/HDRP-1602
https://jira.unity3d.com/browse/HDRP-1603

ref:
#6201

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@skhiat skhiat requested review from kecho and a team December 2, 2021 20:09
@skhiat skhiat changed the title Shadergraph/transparent qol part 2 transparent QoL part 2 - Scene Difference Node Dec 2, 2021
@skhiat skhiat mentioned this pull request Dec 2, 2021
Closed
@skhiat skhiat changed the title transparent QoL part 2 - Scene Difference Node transparent QoL part 2 - Scene Difference Node & Transform Clip space Dec 3, 2021
@skhiat skhiat changed the title transparent QoL part 2 - Scene Difference Node & Transform Clip space [DeadSoon] transparent QoL part 2 - Scene Difference Node & Transform Clip space Dec 3, 2021
@skhiat skhiat changed the title [DeadSoon] transparent QoL part 2 - Scene Difference Node & Transform Clip space Transform Node Clip space only Dec 5, 2021
@skhiat skhiat marked this pull request as ready for review December 5, 2021 23:14
esmelusina
esmelusina approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@esmelusina esmelusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AlixMi
Copy link
Contributor

AlixMi commented Feb 23, 2022

discussed with Soufiane we need to iterate a bit more on that before merge

@skhiat skhiat changed the title Transform Node Clip space only Transform Node Screen Space only Feb 23, 2022
@AlixMi
Copy link
Contributor

AlixMi commented Feb 23, 2022

ok it's good for me!

@skhiat skhiat requested a review from AlixMi February 23, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecho kecho kecho approved these changes

@AlixMi AlixMi AlixMi approved these changes

@esmelusina esmelusina esmelusina approved these changes

@alindmanUnity alindmanUnity Awaiting requested review from alindmanUnity

Assignees

@kecho kecho

Labels
Shader Graph testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skhiat @AlixMi @kecho @esmelusina