Skip to content

Add VolumeComponentArchetype to handle VolumeStack specifically #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

fredericv-unity3d
Copy link
Contributor

Purpose of this PR

This PR illustrate a pattern based on Roslyn Source Generators.
It is about testing its viability on all required platforms.

If this works, it will enable new pattern that can dramatically improve the performances issues occurring at domain reload.


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Oct 15, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@fredericv-unity3d fredericv-unity3d changed the title Testing a pattern with Roslyn Source Generators - Is supported on Add VolumeComponentArchetype to handle VolumeStack specifically Jan 4, 2022
# Conflicts:
#	com.unity.render-pipelines.core/Editor/Volume/VolumeComponentEditor.cs
#	com.unity.render-pipelines.core/Editor/Volume/VolumeComponentProvider.cs
#	com.unity.render-pipelines.core/Runtime/Debugging/VolumeDebugSettings.cs
#	com.unity.render-pipelines.core/Runtime/Volume/VolumeManager.cs
#	com.unity.render-pipelines.core/Tests/Editor/Volumes/VolumeComponentTests.cs
#	com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs
#	com.unity.render-pipelines.high-definition/Runtime/Debug/HDVolumeDebugSettings.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/Bloom.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/ChannelMixer.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/ChromaticAberration.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/ColorAdjustments.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/ColorCurves.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/ColorLookup.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/DepthOfField.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/FilmGrain.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/LensDistortion.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/LiftGammaGain.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/MotionBlur.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/PaniniProjection.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/ShadowsMidtonesHighlights.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/SplitToning.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/Tonemapping.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/Vignette.cs
#	com.unity.render-pipelines.universal/Runtime/Overrides/WhiteBalance.cs
#	com.unity.render-pipelines.universal/Runtime/UniversalRenderPipeline.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant