-
Notifications
You must be signed in to change notification settings - Fork 840
nest and path fixup #5624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
nest and path fixup #5624
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. Shader Graph Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note to other reviewers (I learned a new git thing today - sorry if this is otherwise well known): 'git show' accepts the command line options for 'git diff'. So, 'git show --diff-filter=r ' means "exclude renames". Very useful when you know that most of your 1700 file PR is just straight renames (there are also options to change what git considers a rename by percentage of difference). |
Purpose of this PR
This change nests the editor folder in preparation for breaking future work down into additional editor assemblies.
Testing status
Existing automated tests should be all that's necessary.