Skip to content

nest and path fixup #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

nest and path fixup #5624

wants to merge 7 commits into from

Conversation

esmelusina
Copy link
Contributor


Purpose of this PR

This change nests the editor folder in preparation for breaking future work down into additional editor assemblies.


Testing status

Existing automated tests should be all that's necessary.

@github-actions
Copy link

github-actions bot commented Sep 13, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@esmelusina esmelusina marked this pull request as ready for review September 14, 2021 22:47
@esmelusina esmelusina requested a review from a team as a code owner September 14, 2021 22:47
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebarker
Copy link
Contributor

Note to other reviewers (I learned a new git thing today - sorry if this is otherwise well known):

'git show' accepts the command line options for 'git diff'. So, 'git show --diff-filter=r ' means "exclude renames". Very useful when you know that most of your 1700 file PR is just straight renames (there are also options to change what git considers a rename by percentage of difference).

@esmelusina esmelusina marked this pull request as draft December 2, 2021 18:36
@marctem marctem removed their request for review December 13, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants