[Fix] Motion Vectors: Enable for XR #4707
Conversation
- Replaced cmd.Blit with cmd.DrawMesh. cmd.Blit is not compatible with XR. - Added clear to motion vector pass.
… the depth+msaa issue
...niversalGraphicsTest_Foundation/Assets/Scenes/210_Motion_Vectors/CaptureMotionVectorsPass.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,65 @@ | |||
| Shader "MotionVecDebug" | |||
There was a problem hiding this comment.
Is this used for testing only? Maybe it should be under the https://github.com/Unity-Technologies/Graphics/tree/master/com.unity.testing.urp package.
There was a problem hiding this comment.
Minor naming suggestion
| Shader "MotionVecDebug" | |
| Shader "MotionVectorsDebug" |
There was a problem hiding this comment.
There doesn't seem to be any other test related shaders in that package, why should this one specifically be moved? Other tests have shaders kept in the foundation project.
| - FilteredScene: {fileID: 0} | ||
| FilteredScenes: | ||
| - {fileID: 102900000, guid: 26800f4b3c38849428d29e93038a6084, type: 3} | ||
| ColorSpace: -1 | ||
| BuildPlatform: -2 | ||
| GraphicsDevice: 21 | ||
| XrSdk: | ||
| StereoModes: 0 | ||
| Reason: Needs fix for MSAA+depth | ||
| - FilteredScene: {fileID: 0} | ||
| FilteredScenes: | ||
| - {fileID: 102900000, guid: 26800f4b3c38849428d29e93038a6084, type: 3} | ||
| ColorSpace: -1 | ||
| BuildPlatform: -2 | ||
| GraphicsDevice: 11 | ||
| XrSdk: | ||
| StereoModes: 0 | ||
| Reason: Needs fix for MSAA+depth |
There was a problem hiding this comment.
What are the exceptions being added here for which platforms?
There was a problem hiding this comment.
Excluding new camera motion vector test since there is a bug on vulkan with msaa and depth
com.unity.render-pipelines.universal/Shaders/CameraMotionVectors.shader
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Shaders/ObjectMotionVectors.shader
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Shaders/CameraMotionVectors.shader
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Shaders/CameraMotionVectors.shader
Outdated
Show resolved
Hide resolved
|
Is this PR still active and is it being worked on to merge? |
Purpose of this PR
Enable Motion Vectors for XR and fix some issues with multi pass and camera motion vectors.
When enabling test for xr I noticed that view matrix did not update properly for multi pass, fixed this by uploading view as well.
Testing status
Enabled Object Motion Vector test for XR.
Added test for Camera Motion Vectors (also enabled for XR).
Renamed test scenes to not have a number so close to SSAO scenes.
Camera Motion Vector tests are disabled on GLES3 due to issues with depth and msaa, but running it locally they look correct:
Comments to reviewers
Notes for the reviewers you have assigned.