-
Notifications
You must be signed in to change notification settings - Fork 840
HDRP Metal fixes [Hold] #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: HDRP/staging
Are you sure you want to change the base?
HDRP Metal fixes [Hold] #2044
Conversation
…abled, always treat real as float. Use explicit half precision optimizations instead.
…ATFORM_LANE_COUNT if they're available and device prefers it
…regardless of the OS)
It appears that you made a non-draft PR! |
I really want to do a pass on this. I don't like the way platform 32 vs 64 is handled in this PR. Question. The multicompile 32, is it really a fix or is it just an optimziation? |
I think there are two issues here. One is that we may need a runtime decision based on the actual GPU we see there (versus the Mac that the player was built on). The other is optimization (from the DM thread we had with Antti, he said running with 32 lane count was good for 1-2 ms, but not sure exactly what platform he was testing on). |
Purpose of this PR
With this, should be able to update a bunch of the reference images for MacEditor in HDRP_Tests, but will do that in a separate PR unless reviewers feel strongly.
Testing status
Manual testing with local projects.
Run of HDRP_Tests on Intel GPU to match Bokken agents
Comments to reviewers
This is most of !1795 with some of the pieces removed that are being handled separately/differently. Please let me know if there are still tweaks you'd like to see.