Skip to content

Make raw serializers more lenient #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: neo
Choose a base branch
from
Open

Make raw serializers more lenient #330

wants to merge 2 commits into from

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jul 16, 2025

This PR makes the serializers for EtsRawStmt, EtsRawValue, EtsRawType more lenient, i.e., allow them accept JSONs that use kind discriminator instead of _.

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.74%. Comparing base (da338ff) to head (3aa75b8).
⚠️ Report is 5 commits behind head on neo.

Files with missing lines Patch % Lines
.../src/main/kotlin/org/jacodb/ets/dto/Serializers.kt 45.16% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #330      +/-   ##
============================================
- Coverage     70.19%   69.74%   -0.45%     
+ Complexity     2493     2491       -2     
============================================
  Files           275      275              
  Lines         15462    15573     +111     
  Branches       2307     2345      +38     
============================================
+ Hits          10853    10862       +9     
- Misses         3689     3782      +93     
- Partials        920      929       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Test Results

  215 files  ±0    215 suites  ±0   15m 48s ⏱️ -23s
  711 tests ±0    699 ✅  -  7  12 💤 + 7  0 ❌ ±0 
1 977 runs  ±0  1 927 ✅  - 21  50 💤 +21  0 ❌ ±0 

Results for commit 3aa75b8. ± Comparison against base commit da338ff.

♻️ This comment has been updated with latest results.

@Lipen Lipen requested a review from CaelmBleidd August 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants