Make destination delete button use a modal #1359
Conversation
hmpf
changed the title
Test results 11 files 1 320 suites 49m 59s ⏱️ Results for commit 29697c3. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 78.74% 78.58% -0.16%
==========================================
Files 142 142
Lines 5800 5814 +14
==========================================
+ Hits 4567 4569 +2
- Misses 1233 1245 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stveit
left a comment
stveit
left a comment
There was a problem hiding this comment.
Seems to be working fine, smol thing that sonarcloud picked up on
github-project-automation
bot
moved this from ❓ Ready for review
to ♻ Changes requested
in Argus development, public
github-project-automation
bot
moved this from ♻ Changes requested
to 👍 Reviewer approved
in Argus development, public
johannaengland
left a comment
johannaengland
left a comment
There was a problem hiding this comment.
When I try deleting a destination that is connected to a profile I get the following response:
So somehow it leads to the rest of the page disappearing
| form = DestinationUpdateForm(instance=obj, prefix=f"destination_{obj.pk}") | ||
| form.modal = DeleteModal( | ||
| header="Delete destination", | ||
| explanation=f'Delete destination "{obj}"', |
There was a problem hiding this comment.
| explanation=f'Delete destination "{obj}"', | |
| explanation=f'Delete destination "{obj}"?', |
github-project-automation
bot
moved this from 👍 Reviewer approved
to ♻ Changes requested
in Argus development, public
| <div class="flex w-full h-fit items-center gap-2 justify-center"> | ||
| {% include "htmx/destination/_edit_form.html" %} | ||
| {% include "htmx/destination/_delete_form.html" %} | ||
| {% include form.modal.template_name with modal=form.modal %} |
There was a problem hiding this comment.
Then htmx/destination/_delete_form.html can be deleted
hmpf
force-pushed
the
make-destination-delete-modal
branch
from
c274506 to
29697c3
Compare
|
Scope and purpose
Fixes #1357, depends on #1358
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.