Skip to content

docs(cloudways): warn against using network wildcard in WU_CLOUDWAYS_EXTRA_DOMAINS#1159

Merged
superdav42 merged 1 commit intomainfrom
docs/cloudways-wildcard-ssl-pitfall-1141
May 7, 2026
Merged

docs(cloudways): warn against using network wildcard in WU_CLOUDWAYS_EXTRA_DOMAINS#1159
superdav42 merged 1 commit intomainfrom
docs/cloudways-wildcard-ssl-pitfall-1141

Conversation

@superdav42
Copy link
Copy Markdown
Collaborator

Summary

Updates the in-plugin Cloudways setup wizard to warn against putting your own
network's subdomain wildcard (e.g. *.your-network.com) into
WU_CLOUDWAYS_EXTRA_DOMAINS — a step the previous wording actively
encouraged ("this is useful if you need a wildcard setting").

Combined with a manually-installed Cloudways wildcard SSL certificate, that
configuration prevents Cloudways from issuing Let's Encrypt certificates for
per-tenant custom domains, leaving them without SSL.

Changes

views/wizards/host-integrations/cloudways-instructions.php:

  • Drop the *.yourdomain.com from the example — the new example shows only
    external (non-network) domains.
  • Reframe WU_CLOUDWAYS_EXTRA_DOMAINS as for external domains
    (separate marketing site, parked domain, etc.) — not for the network's
    own subdomain wildcard.
  • Add an Important – Wildcard SSL Pitfall section explaining the
    collision and the recommended setup:
    1. Standard Let's Encrypt cert on Cloudways for your-network.com +
      www.your-network.com only.
    2. No wildcard for the network in WU_CLOUDWAYS_EXTRA_DOMAINS.
    3. Per-tenant wildcard at the DNS level only (A record for
      *.your-network.com → Cloudways IP).
  • Note that the integration always requests standard (non-wildcard) Let's
    Encrypt certs and strips the leading *. from any wildcard supplied in
    WU_CLOUDWAYS_EXTRA_DOMAINS before the SSL request — code reference:
    inc/integrations/providers/cloudways/class-cloudways-domain-mapping.php:197-220
    and class-cloudways-integration.php:203 ('wild_card' => false).

Verification

  • php -l views/wizards/host-integrations/cloudways-instructions.php — no syntax errors.
  • vendor/bin/phpcs views/wizards/host-integrations/cloudways-instructions.php — clean.
  • All new user-facing strings wrapped in esc_html_e() with the
    ultimate-multisite text domain, per AGENTS.md i18n guidance.

Companion PR

Equivalent changes to the public docs site:
Ultimate-Multisite/docs#PENDING (linked once opened)

Issue

Resolves #1141


aidevops.sh v3.14.92 plugin for OpenCode v1.14.40 with gemma4:e4b spent 15h 37m and 263,673 tokens on this with the user in an interactive session.

…EXTRA_DOMAINS

Following the previous wizard guidance, users were including their own
network's subdomain wildcard (e.g. *.your-network.com) in
WU_CLOUDWAYS_EXTRA_DOMAINS. Combined with a manually-installed Cloudways
wildcard SSL certificate, this prevented Cloudways from issuing
Let's Encrypt certificates for per-tenant custom domains, leaving them
without SSL.

- Replace the misleading wildcard example with a non-wildcard one.
- Reframe WU_CLOUDWAYS_EXTRA_DOMAINS as for external domains only.
- Add a prominent 'Wildcard SSL Pitfall' section explaining the
  recommended Cloudways SSL setup (standard Let's Encrypt for the
  network domain, DNS-only wildcard for tenant subdomains).
- Note that the integration always requests standard (non-wildcard)
  Let's Encrypt certificates and strips '*.' from any wildcard
  supplied in WU_CLOUDWAYS_EXTRA_DOMAINS before the SSL request.

Refs #1141
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 8 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1c3d6e4-52f9-4e2d-8481-4d9c1e5f7101

📥 Commits

Reviewing files that changed from the base of the PR and between 996589b and a582a87.

📒 Files selected for processing (1)
  • views/wizards/host-integrations/cloudways-instructions.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/cloudways-wildcard-ssl-pitfall-1141

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superdav42 superdav42 mentioned this pull request May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Performance Test Results

Performance test results for b39762c are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 41 (-8 / -20% ) 37.78 MB (-5.73 MB / -15% ) 727.50 ms 127.50 ms 920.50 ms 1714.00 ms 1638.80 ms 75.85 ms (+1.55 ms / +2% )
1 56 49.12 MB 796.50 ms 124.00 ms (+7.00 ms / +6% ) 921.50 ms (+20.50 ms / +2% ) 1780.00 ms (+80.00 ms / +4% ) 1707.60 ms (+77.45 ms / +5% ) 68.95 ms

@superdav42 superdav42 merged commit 55560d7 into main May 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloudways integration

1 participant