Skip to content

GH#1134: guard checkout editor generated CSS state#1135

Merged
superdav42 merged 1 commit intomainfrom
feature/auto-20260506-025414-gh1134
May 6, 2026
Merged

GH#1134: guard checkout editor generated CSS state#1135
superdav42 merged 1 commit intomainfrom
feature/auto-20260506-025414-gh1134

Conversation

@superdav42
Copy link
Copy Markdown
Collaborator

Summary

Verification

  • vendor/bin/phpcs tests/unit/Checkout_Editor_Assets_Test.php
  • WP_TESTS_DIR=/tmp/wordpress-tests-lib vendor/bin/phpunit --filter Checkout_Editor_Assets_Test

Resolves #1134
Source PR: #1076
Recovered implementation PR: #1077

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 57 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e3b62a89-7dde-4a7f-aa40-83838e5f7739

📥 Commits

Reviewing files that changed from the base of the PR and between 03e03d3 and 6f0e48d.

📒 Files selected for processing (1)
  • tests/unit/Checkout_Editor_Assets_Test.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260506-025414-gh1134

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superdav42
Copy link
Copy Markdown
Collaborator Author

Completion Summary

@superdav42 superdav42 added origin:worker Auto-created by pulse labelless backfill (t2112) status:in-review PR open, awaiting review/merge labels May 6, 2026
@superdav42 superdav42 force-pushed the feature/auto-20260506-025414-gh1134 branch from 6280f4a to 6f0e48d Compare May 6, 2026 09:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Performance Test Results

Performance test results for 8259ce4 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 40 37.74 MB 844.00 ms 157.00 ms (-10.50 ms / -7% ) 1074.00 ms (+27.50 ms / +3% ) 2070.00 ms (+54.00 ms / +3% ) 1985.05 ms (+69.15 ms / +3% ) 92.45 ms
1 56 49.11 MB 962.00 ms (+20.00 ms / +2% ) 147.50 ms (-3.00 ms / -2% ) 1107.50 ms 2106.00 ms (+54.00 ms / +3% ) 2023.45 ms (+58.15 ms / +3% ) 83.65 ms

@superdav42 superdav42 merged commit e989509 into main May 6, 2026
11 checks passed
@superdav42
Copy link
Copy Markdown
Collaborator Author

Completion Summary


Merged via PR #1135 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).


aidevops.sh v3.14.75 spent 1m on this as a headless bash routine.

@superdav42
Copy link
Copy Markdown
Collaborator Author

Completion Summary


Merged via PR #1135 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).


aidevops.sh v3.14.75 spent 1m on this as a headless bash routine.

@superdav42
Copy link
Copy Markdown
Collaborator Author

Closing Summary

What done

Added regression coverage for the recovered checkout editor generated-CSS state. PR #1077 had already recovered and merged the valuable PR #1076 asset revert, so PR #1135 adds durable verification for #1134 without making further asset changes.

Testing Evidence

  • vendor/bin/phpcs tests/unit/Checkout_Editor_Assets_Test.php
  • WP_TESTS_DIR=/tmp/wordpress-tests-lib vendor/bin/phpunit --filter Checkout_Editor_Assets_Test
  • GitHub checks on PR GH#1134: guard checkout editor generated CSS state #1135 passed: Code Quality Checks, PHP Lint, PHP 8.2/8.3/8.4/8.5, WP Performance Metrics, Build Plugin for Testing, Cypress 8.1/8.2, CodeRabbit.

Key decisions

Files changed

  • tests/unit/Checkout_Editor_Assets_Test.php

Blockers

None.

Follow-up

None required.

Released in

Merged via PR #1135.


aidevops.sh v3.14.75 plugin for OpenCode v1.14.33 with gpt-5.5 spent 19m and 208,781 tokens on this as a headless worker.

@superdav42 superdav42 deleted the feature/auto-20260506-025414-gh1134 branch May 7, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:worker Auto-created by pulse labelless backfill (t2112) status:in-review PR open, awaiting review/merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recover closed-unmerged PR #1076: GH#1074: revert manually committed checkout-editor.min.css to pre-PR state

1 participant