Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TyHil
approved these changes
Mar 4, 2026
Member
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
Looks good!
May be worth removing a lot of the comments in jest.config.ts tho.
And your PR description would be good to keep around, maybe it could go in like a docs/testing.md file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Tests are written with Jest. To run tests, type
npm run test. Tests should be run and passing when making or merging a PR.Test scripts are located in the
__tests__folder.Mock files necessary for the tests should be located in the
mocksfolder. Use mocks for any necessary data, but use theTesting philosophy: test components with significant internal processing or logic. Keep tests as independent of details and implementation as possible.