-
Notifications
You must be signed in to change notification settings - Fork 2
Allow for External Dropdown State Control #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krowvin
wants to merge
8
commits into
main
Choose a base branch
from
dropdown-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
abeebc8
Formatting of lib dropdown
krowvin 2298b77
Make the dropdown handle external state management
krowvin 2bd330e
Update the documentation to both use external state management and sh…
krowvin cd203ac
* Correct variable name.
krowvin f31d6b4
Add a reference to the select attributes on mdn
krowvin 614ba05
Merge branch 'main' into dropdown-state
krowvin b5c03dc
Remove internal state for passed in value/defaultValue/props
krowvin af0f537
Update docs to reflect explicit value/defaultValue options
krowvin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import { useState } from "react"; | ||
| import gwMerge from "../../gw-merge"; | ||
|
|
||
| function Dropdown({ | ||
|
|
@@ -7,15 +6,17 @@ function Dropdown({ | |
| labelClassName = "", | ||
| className = "", | ||
| onChange, | ||
| value, | ||
| defaultValue, | ||
| ...props | ||
| }) { | ||
| const [selectedValue, setSelectedValue] = useState(options[0]?.value); | ||
| if (!options || options.length === 0) { | ||
| console.error( | ||
| `Dropdown ${label} must have at least one option with value and text.`, | ||
| ); | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <label | ||
|
|
@@ -30,16 +31,14 @@ function Dropdown({ | |
| <select | ||
| id={label} | ||
| name={label} | ||
| onChange={(e) => { | ||
| setSelectedValue(e.target.value); | ||
| onChange(e); | ||
| }} | ||
| onChange={onChange} | ||
| className={gwMerge( | ||
| "gw-mt-2 gw-block gw-w-full gw-rounded-md gw-border-0 gw-py-1.5 gw-pl-3 gw-pr-10 gw-text-gray-900 gw-ring-1 gw-ring-inset gw-ring-gray-300 focus:gw-ring-2 focus:gw-ring-indigo-600 sm:gw-text-sm sm:gw-leading-6", | ||
| className, | ||
| )} | ||
| value={value} | ||
| defaultValue={defaultValue} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the component is intended to be React-controlled I don't think we'd want to include a |
||
| {...props} | ||
| value={selectedValue} | ||
| > | ||
| {options} | ||
| </select> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to include this modal formatting in this PR?