-
Notifications
You must be signed in to change notification settings - Fork 2
Accordion Props to Control State #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Please set a versioning label of either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
|
Will remove id for props spread and test to make sure multiple still work |
|
id removed, ready for merge/review |
willbreitkreutz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just pass all props down to the Accordion body rather than just the id
This pull request includes significant updates to the
Accordioncomponent to enhance its functionality and documentation. The most important changes include updating the import statements, adding new props to theAccordioncomponent, and updating the documentation to reflect these changes.Enhancements to
Accordioncomponent:lib/components/display/accordion.jsx: Updated the import statements to includeDisclosureButtonandDisclosurePanelfrom@headlessui/react.lib/components/display/accordion.jsx: Added new propsisOpen,onToggle, andidto theAccordioncomponent to allow for more control over its state and behavior.Documentation updates:
src/app-pages/documentation/display/accordion.jsx: Updated the documentation to include descriptions for the new propsclassName,isOpen,onToggle,children, andid.