Conversation
What we were using is already the default
Pl217
added
needs unit tests
needs minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@manelcecs I noticed that running tests multiple times in a row in this repo shows that we're not doing proper cleanup after they finish running. The errors seen are lots of
Unable to connect to Postgres via Knex. Ensure a valid connectioneverywhere.Closing the DB connection after finishing tests, which I did, didn't resolve the problem. Since you worked on setting up tests in #26, I'll let you take care of this.