fix(ui5-shellbar): prevent search auto-expand on non-desktop resize - #14025
Merged
Conversation
On phones and tablets, rotating the device triggers the ShellBar's resize-based auto-expand logic, opening the full-screen search dialog without any user intent. Guard the expand branch in both ShellBarSearch and ShellBarSearchLegacy with isDesktop() so that auto-expansion from resize events is limited to desktop environments. On non-desktop devices, expansion must come from an explicit user tap on the search icon. Fixes: auto-open of full-screen search on phone/tablet orientation change SNOW: CS20260013061846
dobrinyonkov
self-requested a review
September 4, 2026 08:26
|
🚀 Deployed on https://pr-14025--ui5-webcomponents-preview.netlify.app |
dobrinyonkov
approved these changes
Sep 4, 2026
|
🧹 Preview deployment cleaned up: https://pr-14025--ui5-webcomponents.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On phones and tablets, rotating the device triggers the ShellBar's resize-based auto-expand logic, opening the full-screen search dialog without any user intent.
Guard the expand branch in both ShellBarSearch and ShellBarSearchLegacy with isDesktop() so that auto-expansion from resize events is limited to desktop environments. On non-desktop devices, expansion must come from an explicit user tap on the search icon.
Fixes: auto-open of full-screen search on phone/tablet orientation change
SNOW: CS20260013061846