Skip to content

feat(ui5-toolbar-button): add accessibleRole property - #13979

Open
plamenivanov91 wants to merge 1 commit into
mainfrom
tbb-acc-role
Open

feat(ui5-toolbar-button): add accessibleRole property#13979
plamenivanov91 wants to merge 1 commit into
mainfrom
tbb-acc-role

Conversation

@plamenivanov91

Copy link
Copy Markdown
Contributor

Forwards accessibleRole to the inner ui5-button, enabling consumers to expose the toolbar action as a link (role="link") for navigation use cases, resolving the A11y gap reported by SuccessFactors.

Fixes #13070

Forwards accessibleRole to the inner ui5-button, enabling consumers
to expose the toolbar action as a link (role="link") for navigation
use cases, resolving the A11y gap reported by SuccessFactors.

Fixes #13070
@plamenivanov91
plamenivanov91 deployed to netlify-preview August 25, 2026 08:46 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown

👋 Heads-up: dev close is in effect

Thanks for the contribution! This repository is currently in dev close ahead of release 2.26 (scheduled 2026-08-26, UTC). See the release schedule for the full timeline.

This PR appears to introduce public-API changes (detected by diffing the Custom Elements Manifest against the latest published version on npm):

@ui5/webcomponents

  • ➕ added property: accessibleRole
  • ➕ added attribute: accessible-role
  • 🔄 changed attribute design (type)

Could you please hold off on merging into main until the release ships? Public-API changes are best landed in the next dev cycle so they don't slip into the release at the last minute. Once the release is out, this PR is good to go.

If this change must ship in the current release, please request a review from one or two members of @UI5/ui5-team-webc so the team can sign off explicitly.

💬 False positive? If you believe this PR doesn't actually change the public API (e.g. only internal refactoring, or an entry the detector mis-attributed), please reply on this thread — your feedback helps us improve the detection during this trial run.

Posted automatically by the Dev Close Notice workflow.

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SF][ToolbarButton][A11y]:[Missing accessibleRole prop for ToolbarButton]

1 participant