perf(LiveView): 'Apply filters when not searching' is much faster now #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs makes the
Apply filters when not searchingoption create a result-set instead of applying each filter during every iteration of GUObjectArray.This PR also adds a compile-time debugging flag,
RC_LIVE_VIEW_DEBUG_FILTER_RESULTS, that can be used to dump the reason why an object was filtered out from the live view.It's off by default, and developers can change the code at around line 1930 in LiveView.cpp if they want to only dump the reasons for specific object(s).
It can be enabled in
UE4SS/include/GUI/LiveView/Filter/SearchFilter.hppType of change
How has this been tested?
Apply some filters, and tick the
Apply filters when not searchingcheckbox.Verify that objects that you expect to find in the results actually appear.
Checklist