Use our own patternsleuth fork #1084
Open
+49
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the patternsleuth submodule to use our own fork.
This was done because upstream is too slow to pull in changes.
We can go back to upstream in the future if we want to, or we could stay on our own fork and keep merging in upstream from time to time, i.e. soft fork.
The fork has a much better resolver for
UGameEngine::Tick, which should now be found consistently enough to be usable.This PR also makes
UGameEngine::Tickoverridable byUE4SS_Signatures/GameEngineTick.lua.Update: Upstream merged our changes, but we still need to merge this PR because upstream introduced breaking changes, and I'd like to have our own soft fork of PS anyway so that we're not dependent on the speed of the upstream maintainers.