Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50 , Closes #9
Integrates the new QC workflow into the enigma-pd-wml pipeline:
Adds extra python dependencies needed for QC (mainly
matplotlib). To allow both these dependencies and FSL to be managed together, I modified theDockerfileto use miniforge to install dependencies listed in anenvironment.yamlfile. This contains the set of FSL conda packages needed by the workflow + QC dependencies. The added benefit of this new approach is the overall image size is reduced by about 50%, by only doing a partial install of FSL.Moves
analysis_script.sh, and the new QC files (png_generator.py+MAKE_HTML.sh) into a sub-dir calledsrc. This makes it easier to copy them all together in theDockerfile, and makes them easier to find in the repo.I made some modifications to the
PNG_GENERATOR.shscript:png_generator.py, as it was mostly an embedded python file in a bash scriptresults2mni_{reg_type}_combined.nii.gzdata_dir(the directory containing outputs for a single session), andoutdir(the directory to write png images to). As thedata_dirhas a standard filepath structure, we can extract the subject / session ids directly from this.PNGdir in folders named likesub-1-ses-1,sub-1-ses-2etc.I made some modifications to the
MAKE_HTML.shscript.subjects.txtinput parameter - now it gets these names by listing the directories inside the PNG dir directly.generate_html_for_registrationfunction to below, as I think this is easier to follow (do move back if you would prefer though)Updated non-bids processing to always write to a set output structure (matching the bids
derivativesdir). This required adding asubjectandsessioncolumn to the input csv file (see updatednon-bids-data.md)Updated docs to match the new pipeline, and integrated the QC docs from the shared word doc (with some edits to fit it in with the rest of the docs). I split this into two files:
qc_usage.mdandqc_pipeline.md. One focuses on how to use the QC tool, while the other describes the technical details of how the QC pipeline works.