Skip to content
This repository was archived by the owner on May 18, 2024. It is now read-only.

C++ workspace docs updates #91

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

C++ workspace docs updates #91

wants to merge 5 commits into from

Conversation

hhenry01
Copy link
Member

@hhenry01 hhenry01 commented Nov 4, 2022

Update C++ docs to reflect the structure and style established in the C++ workspace setup

@hhenry01 hhenry01 added the docs Improvements or additions to documentation label Nov 4, 2022
@hhenry01 hhenry01 self-assigned this Nov 4, 2022
DFriend01
DFriend01 suggested changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. There is a new linter in this repo, so please merge with main and apply the linting rules to your markdown.

@patrick-5546 patrick-5546 removed their request for review November 12, 2022 08:38
@hhenry01 hhenry01 force-pushed the hhenry01/NET-workspace-structure branch 2 times, most recently from 3489516 to b4df58d Compare November 19, 2022 08:23
@hhenry01 hhenry01 requested a review from DFriend01 November 19, 2022 08:24
DFriend01
DFriend01 previously approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@patrick-5546
Copy link
Member

patrick-5546 commented Feb 25, 2023 •
edited
Loading

Looks like we forgot about this, is this PR still valid? Can it be merged?

@patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 marked this pull request as draft March 22, 2023 23:22
@patrick-5546 patrick-5546 requested a review from DFriend01 June 15, 2023 17:37
patrick-5546
patrick-5546 reviewed Sep 1, 2023
View reviewed changes
DFriend01
DFriend01 reviewed Sep 1, 2023
View reviewed changes
docs/current/network_systems/repo_structure.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like most, if not all of this information in this file, might belong on the project README rather than the docs website. How do others feel about this? @patrick-5546 @hhenry01?

@DFriend01 DFriend01 dismissed their stale review September 1, 2023 19:44

Upon re-reviewing, some of the information provided may be best placed elsewhere

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patrick-5546 patrick-5546 patrick-5546 left review comments

@DFriend01 DFriend01 DFriend01 left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees

@hhenry01 hhenry01

Labels
docs Improvements or additions to documentation update-page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create docs page Sailbot Workspace/Debugging
3 participants
@hhenry01 @patrick-5546 @DFriend01