feat(endpoints): add domain-expiration-only-check #1360
Conversation
qianlongzt
force-pushed
the
feat-endpoint-domain
branch
from
2abf238 to
9694008
Compare
|
@TwiN Is there anything I can do to help merge PR? Is there no progress? |
test result cpu: AMD Ryzen 7 4800H with Radeon Graphics BenchmarkEndpoint_Type-16 Cut + switch 5053628 238.7 ns/op 0 B/op 0 allocs/op Cut + map 2714998 438.6 ns/op 0 B/op 0 allocs/op switch HasPerfix 2683519 430.9 ns/op 0 B/op 0 allocs/op
qianlongzt
force-pushed
the
feat-endpoint-domain
branch
from
9694008 to
8a079be
Compare
|
@PythonGermany Your PR qianlongzt#1 looks good to me, but what should I do next? |
|
@qianlongzt Just merge my changes into your branch. |
Refactor endpoint call method
| before, _, ok := strings.Cut(e.URL, ":") | ||
| if !ok { | ||
| return TypeUNKNOWN | ||
| } | ||
| switch before { | ||
| case "tcp": | ||
| return TypeTCP | ||
| case strings.HasPrefix(e.URL, "sctp://"): | ||
| case "sctp": | ||
| return TypeSCTP | ||
| case strings.HasPrefix(e.URL, "udp://"): | ||
| case "udp": | ||
| return TypeUDP | ||
| case strings.HasPrefix(e.URL, "icmp://"): | ||
| case "icmp": |
There was a problem hiding this comment.
I understand and appreciate your intention to simplify the code, but personally, having the ability to do a global search for <protocol/endpoint-type>:// (e.g. icmp://) makes navigating the code much easier (reasoning here being that if you search for just http instead of http://, you're going to get hundreds of results as opposed to exactly what you're looking for).
Could you revert the changes here and update the new domain:// prefix accordingly?
There was a problem hiding this comment.
Should we add quotation marks to the search string, for example "icmp" and "http"?
| type testEndpoint_typeArgs struct { | ||
| URL string | ||
| DNS *dns.Config | ||
| SSH *ssh.Config | ||
| } | ||
|
|
||
| var testEndpoint_typeData = []struct { |
There was a problem hiding this comment.
The whole Test<something>_<something> notation is more intended to be for the struct name followed by the method name (and occasionally further details).
Is there any reason why you moved those outside of the function? They're only used in the function, you could just name them typeArgs and typeData within the TestEndpoint_Type test function itself
There was a problem hiding this comment.
I just want BenchmarkEndpoint_Type to reuse the same test data as TestEndpoint_Type.
This benchmark is for both the old and new Type implementations, and I would like to keep it in the tests.
3 participants
Summary
test result for perfomance
cpu: AMD Ryzen 7 4800H with Radeon Graphics
BenchmarkEndpoint_Type-16
Cut + switch 5053628 238.7 ns/op 0 B/op 0 allocs/op
Cut + map 2714998 438.6 ns/op 0 B/op 0 allocs/op
switch HasPerfix 2683519 430.9 ns/op 0 B/op 0 allocs/op
Checklist
README.md, if applicable.