Allow using cloud variables for projects uploaded from files and in the editor #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was leaking to lower HOCs
…editor For projects from files, we generate a room ID from the title (similar to the packager). In the editor, we prefix the room ID so that cloud variables still work but remain separate from variables outside of the editor. Closes #645
Previous commit makes cloud variables available in the editor
|
unsolved issues:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
projects loaded by URL would be given a project ID based on the URL, so no concern about making "hacking" easier at all note that cloud variables are an inherently insecure system regardless of this PR |
that makes sense |
|
The bottom of this page says there is a conflict. |
|
yes this has not really been a priority for 3 years |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #645