Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
Why are you making it?
To resolve
NY-382. The "Growth" tab in post analytics was incorrectly displayed even when the "Member Sources" setting was disabled, leading to inconsistent UI and user confusion.What does it do?
This PR conditionally hides the "Growth" tab in the post analytics header. The tab will now only be visible if the
members_track_sourcessetting is enabled. An e2e test has been added to verify this behavior.Why is this something Ghost users or developers need?
Users: Ensures a consistent and logical experience. If member source tracking is disabled, users expect related analytics to be hidden, preventing confusion and improving trust in the analytics data.
Developers: Improves the accuracy of the UI based on settings and adds a robust e2e test to prevent regressions.
Please check your PR against these items:
We appreciate your contribution! 🙏
Linear Issue: NY-382