Skip to content

Conversation

@prschulz
Copy link
Contributor

@prschulz prschulz commented Jan 8, 2026

Got some code for us? Awesome 🎊!

Please take a minute to explain the change you're making:

  • Why are you making it?
    To resolve NY-382. The "Growth" tab in post analytics was incorrectly displayed even when the "Member Sources" setting was disabled, leading to inconsistent UI and user confusion.

  • What does it do?
    This PR conditionally hides the "Growth" tab in the post analytics header. The tab will now only be visible if the members_track_sources setting is enabled. An e2e test has been added to verify this behavior.

  • Why is this something Ghost users or developers need?
    Users: Ensures a consistent and logical experience. If member source tracking is disabled, users expect related analytics to be hidden, preventing confusion and improving trust in the analytics data.
    Developers: Improves the accuracy of the UI based on settings and adds a robust e2e test to prevent regressions.

Please check your PR against these items:

  • I've read and followed the Contributor Guide
  • I've explained my change
  • I've written an automated test to prove my change works

We appreciate your contribution! 🙏


Linear Issue: NY-382

Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Jan 8, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants