-
Notifications
You must be signed in to change notification settings - Fork 0
Code review process
Steven Than edited this page Jan 29, 2019
·
2 revisions
- [Reminder] Run
npm run testbefore creating pull request, Travis CI will also run tests for you, but it's much slower than your local environment - Create pull requests
- [Optional] Tag the person who you would like to be your reviewer
- A notification will be sent to
visual-teamslack channel, if nobody is tagged as reviewer, anyone can review the pull request - If there are comments, read them and make sure they are resolved
- If there's a need for changes, you can keep the pushing commits onto the same branch, notify your reviewer when new codes are added for further review
- [MOST IMPORTANTLY] DO NOT TAKE PR COMMENTS PERSONAL, IT'S ABOUT YOUR CODE, NOT ABOUT YOU
- Keep tab on slack channel for new pull request (Ideally a pr should be reviewed within the day to keep the development process going)
- Go through every file in the
Files changedtab (evenpackage.json) and give your comments, be considerate and thorough with your comments - Clone and run the pull request locally to make sure everything looks good, and nothing is breaking (this step won't be necessary anymore once we are able to spin up an AWS for each pull request)
- Give your approval and merge the pull request