Skip to content

Feature: trending stories makeover#144

Open
steventhan wants to merge 5 commits intomasterfrom
feature/trending-stories-makeover
Open

Feature: trending stories makeover#144
steventhan wants to merge 5 commits intomasterfrom
feature/trending-stories-makeover

Conversation

@steventhan
Copy link
Copy Markdown
Contributor

No description provided.

@steventhan steventhan temporarily deployed to truthtree-frontend-pr-144 April 18, 2019 06:48 Inactive
@steventhan steventhan temporarily deployed to truthtree-frontend-pr-144 April 18, 2019 12:43 Inactive
@sheelasathyanarayana
Copy link
Copy Markdown
Contributor

I kind of end up clicking back icon in browser, it does not go back to the page I intended to. Also, I like that I could scroll through other stories while viewing this one. But your implementation is good too. Or can we try going to your implementation from the previous view - if the user wants to see a larger version. Just my thoughts

@steventhan
Copy link
Copy Markdown
Contributor Author

steventhan commented Apr 19, 2019

I kind of end up clicking back icon in browser, it does not go back to the page I intended to. Also, I like that I could scroll through other stories while viewing this one. But your implementation is good too. Or can we try going to your implementation from the previous view - if the user wants to see a larger version. Just my thoughts

Yea so the reason was that the previous version is not very mobile responsive and thus not displaying images too well. For example, the post about cactus that has a big image, every thing was overflowing and has both vertical and horizontal scroll, moving to this design would address that. Additionally, the whole container is restrained with less than 500px in height so opening in a bigger screen like 15 inch laptop or 22+ inch monitor would have a lot of whitespace.

Regarding the back button, this is just a quick implementation, so there's no react-router involvement yet since we're so close to the deadline. However, ideally in the future, we'll have a story detail page with proper story id and such in the url, so that users can share a particular story that they found interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants