chore: update signing lib and pass body as byte[] #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TrueLayer.Signing package from version 0.2.2 to 0.2.4 and refactors the request signing implementation to use byte arrays instead of strings for improved efficiency.
- Updated TrueLayer.Signing package dependency from 0.2.2 to 0.2.4
- Refactored request body handling to use
JsonSerializer.SerializeToUtf8Bytes()instead of string serialization - Changed HTTP content creation from
StringContenttoByteArrayContentwith explicit content type header
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/TrueLayer/TrueLayer.csproj | Updated TrueLayer.Signing package reference to version 0.2.4 |
| src/TrueLayer/ApiClient.cs | Refactored signing implementation to use byte arrays; removed obsolete System.Text import; replaced StringContent with ByteArrayContent |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
tl-luca-baggi
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.