Skip to content

fix(ci): add cargoWorkspacePath to cargo-workspace plugin #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yordis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): add cargoWorkspacePath to cargo-workspace plugin #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
},
{
"type": "cargo-workspace",
"cargoWorkspacePath": "rsworkspace",
Copy link
Copy Markdown

@cursor cursor bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported config option added instead of removing plugin

High Severity

The PR title and description say to remove the cargo-workspace plugin, but the actual change keeps the plugin and adds a cargoWorkspacePath option. The PR description itself states that upstream PR googleapis/release-please#2682 (which adds cargoWorkspacePath support) is "open PR, not yet merged." This means release-please won't recognize the cargoWorkspacePath option, and the workflow will likely still fail with the same Failed to find file: Cargo.toml error.

Fix in Cursor Fix in Web

"merge": false
}
],
Expand Down
Loading