feat(nanoviews): rename effect attributes from $$name to name$ - #188
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 83.96% 83.96%
=======================================
Files 138 138
Lines 2988 2988
Branches 564 564
=======================================
Hits 2509 2509
Misses 340 340
Partials 139 139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames all effect attributes to the
name$convention, since the oldname$meaning is gone:$$autoFocus->autoFocus$,$$checked->checked$,$$classList->classList$,$$files->files$,$$ref->ref$,$$selected->selected$,$$style->style$,$$value->value$.Also updates README, weather examples, size-limit config, and adds type tests for
if_value narrowing.🤖 Generated with Claude Code