Skip to content

WIP: Remove M2Crypto #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vandenheuvel wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

WIP: Remove M2Crypto #544

vandenheuvel wants to merge 4 commits into from

Conversation

@vandenheuvel
Copy link

@vandenheuvel vandenheuvel commented Jun 3, 2017 •
edited
Loading

  • Removing M2Crypto
  • Minor issues in the code
  • Updating CI

@tribler-ci
Copy link

tribler-ci commented Jun 3, 2017

Can one of the admins verify this patch?

@devos50
Copy link
Contributor

devos50 commented Jun 3, 2017

ok to test

@tribler-ci
Copy link

tribler-ci commented Jun 3, 2017

Can one of the admins verify this patch?

@devos50
Copy link
Contributor

devos50 commented Jun 3, 2017

Note that we might want to use lower-security curves during experiments so I would at least keep the possibility to use curves that are faster. @qstokkink what is your opinion on this?

@qstokkink
Copy link
Contributor

qstokkink commented Jun 3, 2017

@devos50 We use that a lot, so I would say we keep that feature.

@vandenheuvel vandenheuvel force-pushed the remove_m2crypto branch 6 times, most recently from f26ff21 to 6cef7d0 Compare June 4, 2017 18:21
@vandenheuvel vandenheuvel changed the title WIP: Remove M2Crypto and replace all curves with Curve25519 WIP: Remove M2Crypto Jun 4, 2017
@vandenheuvel vandenheuvel force-pushed the remove_m2crypto branch 2 times, most recently from 9203296 to fbc6a23 Compare June 4, 2017 19:30
@qstokkink
Copy link
Contributor

qstokkink commented Jul 3, 2017

Here's how I did this in ipv8:

https://github.com/qstokkink/py-ipv8/blob/master/keyvault/public/m2crypto.py
https://github.com/qstokkink/py-ipv8/blob/master/keyvault/private/m2crypto.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vandenheuvel @tribler-ci @devos50 @qstokkink @MaxVanDeursen