Skip to content

Shipsave Security Fix, Code Cleanup, and Other Shipsave Tweaks#19

Merged
DDrakov merged 4 commits intoTriad-Sector:mainfrom
TheRealMasterChief117:shipsave-security-fix
Apr 27, 2026
Merged

Shipsave Security Fix, Code Cleanup, and Other Shipsave Tweaks#19
DDrakov merged 4 commits intoTriad-Sector:mainfrom
TheRealMasterChief117:shipsave-security-fix

Conversation

@TheRealMasterChief117
Copy link
Copy Markdown
Contributor

@TheRealMasterChief117 TheRealMasterChief117 commented Apr 27, 2026

About the PR

  • Fixed a security vulnerability with the ship saving deleting your local ship files.
  • Added sawmills to the shipsave systems.
  • Shipyard console now sends a radio message when storing a ship
  • Shipyard console now updates the ID card inserted into the console upon saving

Technical details

Prevents the server from deleting files that aren't in the ship-save paths Space Station 14/data/Exports/
File paths now need to be explicitly allowed by the client in order for the server to be able to delete them

Media

Backups, saving and loading ship seems to work well

Screenshot_20260427_160424 Screenshot_20260427_160625 Screenshot_20260427_160636

Requirements

  • I have read relevant guidelines/documentation to this PR found on our devwiki.
  • I have added media to this PR or it does not require an ingame showcase.
  • I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

Changelog
🆑

  • fix: Fixed some security vulnerabilities regarding shipsaving.
  • add: Saving a ship now sends a radio message to shortband.
  • fix: Fixed the shipyard console not updating the ID card in the console upon saving the ship.

TheRealMasterChief117 and others added 3 commits April 27, 2026 14:55
Co-authored-by: Copilot <copilot@github.com>
@Triad-Sector Triad-Sector changed the title Shipsave security fix, code cleanup, and other shipsave tweaks Shipsave Security Fix, Code Cleanup, and Other Shipsave Tweaks Apr 27, 2026
@DDrakov
Copy link
Copy Markdown
Collaborator

DDrakov commented Apr 27, 2026

Tested and works

@DDrakov DDrakov merged commit fc38370 into Triad-Sector:main Apr 27, 2026
14 checks passed
Triad-Sector added a commit that referenced this pull request Apr 27, 2026
@TheRealMasterChief117 TheRealMasterChief117 deleted the shipsave-security-fix branch April 28, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants