Handle @property redefinition in subclasses #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexECX
changed the title
AlexECX
force-pushed
the
Handle-property-redefinition-in-subclasses
branch
2 times, most recently
from
23c31e3 to
0598f21
Compare
AlexECX
force-pushed
the
Handle-property-redefinition-in-subclasses
branch
from
0598f21 to
d0b6188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Redefining a
@propertyin a subclass will cause the transpiled code to raise aTypeError: Cannot redefine propertyerror in javascript. This PR adds theconfigurableattribute to@propertydescriptors, allowing them to be redefined byObject.defineProperty.Related issue number
Related to #690.
PR Checklist