Quote loading state is very glitchy, resolves FRONT-915#100
Open
yasha-meursault wants to merge 5 commits intodevfrom
Open
Quote loading state is very glitchy, resolves FRONT-915#100yasha-meursault wants to merge 5 commits intodevfrom
yasha-meursault wants to merge 5 commits intodevfrom
Conversation
different token pairs), which can flash incorrect pricing. Using a ref ensures stale data is only shown while the same key is revalidating and is cleared on errors.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
block the buttons while the quote loads fix issue with small amoutns failing validation due to JS scientific notation conversion. fix by regex testing the raw input string instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWR's keepPreviousData retains stale quotes across key changes (e.g. different token pairs), which can flash incorrect pricing. Using a ref ensures stale data is only shown while the same key is revalidating and is cleared on errors.