Open
Conversation
Conflicts: analysis/topEFT/topeft.py topcoffea/json/params.json topcoffea/modules/objects.py topcoffea/modules/selection.py
bryates
commented
Jun 16, 2025
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "xsec": 2.2471, | |||
| "xsec": 2.9922, | |||
Contributor
Author
There was a problem hiding this comment.
What was this change to the xsec? Was that the 33% correction? If so, we should consider moving that somewhere else instead of overwriting the xsec, just to make it more clear for future users.
Collaborator
There was a problem hiding this comment.
Good point. Do you suggest moving that info directly inside the analysis processor where if ttgamma sample is being used, we scale the xsec by 1.33? In any case, neither of the approach should be permanent anyway cause like Kevin said, scaling cross-section won't be a physically correct thing to do.
Contributor
Author
There was a problem hiding this comment.
It might be best to store that factor somewhere in a json/yml file.
anpicci
added a commit
that referenced
this pull request
Nov 11, 2025
…ions-for-custom-bins Revert "Rebin stacked ratio plots with custom bin edges"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the
photonsbranch tohistEFT.