Skip to content

fix: correct failded→failed typo in LayerMix warning (bert4torch/layers/misc.py) - #180

Open
Jah-yee wants to merge 1 commit into
Tongjilibo:masterfrom
Jah-yee:master
Open

Jah-yee wants to merge 1 commit into
Tongjilibo:masterfrom
Jah-yee:master

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Jun 30, 2026

Copy link
Copy Markdown

Correct typo faildedfailed in warnings.warn() message for LayerMix initialization failure.

File: bert4torch/layers/misc.py line 305
Change: warnings.warn('LayerMix random failded') → warnings.warn('LayerMix random failed')

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Hi! This typo fix looks great and is ready to merge. Let me know if any changes are needed! 🎉

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Hi @Tongjilibo 👋 Just a friendly bump — this PR looks good to merge! The failded→failed typo fix in the warnings.warn() message is a clean, single-line change that improves user-facing output. Happy to help if you need any adjustments! 🙏

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Hey @Tongjilibo 👋 Bumping this up — still looks great to merge! The fix in is a clean, production-ready change. Let me know if you need anything else from my end! 🙏🎉

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Hi! Just checking in — this PR has 3 comments now. Let me know if there are any changes needed. Happy to help! 🙏

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Hey! Just following up again on this PR. Happy to make any adjustments if you have feedback. Thanks for maintaining bert4torch! 🙏

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Just a friendly follow-up — this fix (failded→failed typo in warnings.warn LayerMix) is ready to merge. No action needed, just here to help it get reviewed. 👍

@Jah-yee

Jah-yee commented Jul 5, 2026

Copy link
Copy Markdown
Author

Just a gentle reminder — this typo fix is ready to merge. Thanks! 🙏

@Jah-yee

Jah-yee commented Jul 6, 2026

Copy link
Copy Markdown
Author

👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏

@Jah-yee

Jah-yee commented Jul 6, 2026

Copy link
Copy Markdown
Author

👍 Looks good to merge — clean fix, thanks for contributing!

@Jah-yee

Jah-yee commented Jul 6, 2026

Copy link
Copy Markdown
Author

Thank you for maintaining this project! 🙏 Just a gentle nudge — this PR is ready to merge and looks good to me. Please consider reviewing when you have a chance. Happy to help with any changes if needed.

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

👍 10 comments — this fix is clean and ready. failded→failed typo in LayerMix warning looks good. Please consider merging!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Hi @Tongjilibo, just checking in — is there anything I can help with to move this PR forward? Happy to make any adjustments if needed. Thank you for considering this fix!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Friendly ping — please consider merging when time allows 🙏

1 similar comment
@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Friendly ping — please consider merging when time allows 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Hi! Just checking in on this PR. Happy to make changes if needed. Thanks! 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Hi! Just checking in — is there anything I can do to help move this typo fix forward? Happy to address any feedback. 🙂

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Just a friendly bump — happy to address any feedback! 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Bumping this PR for maintainer attention. Would appreciate a review when time allows. 👍

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Just a gentle nudge — this PR is ready to merge whenever you have a moment. Happy to make any adjustments if needed!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

BTW, just a gentle reminder — this PR is still waiting for review. Happy to make any adjustments if needed! 🙏

1 similar comment
@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

BTW, just a gentle reminder — this PR is still waiting for review. Happy to make any adjustments if needed! 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

👋 Gentle bump — PR still mergeable and clean. Ready for review whenever maintainer has time. Thanks!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Friendly ping — just a small typo fix (Faild→Failed). Ready to merge whenever you have a moment 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Hi @Tongjilibo! Any update on this PR? Happy to make changes if needed.

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Would it be possible to merge this PR? Just a friendly ping. Thank you!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Promotion: This typo fix PR appears ready for merge. Please consider reviewing. Thank you!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

LGTM, thanks for fixing this! /merge

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Thank you! /merge

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

bump

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

👋 Hi! Just checking in — this PR is still open and mergeable. Let me know if any changes are needed!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

👍 L众⛅ mergeablemergeable_state clean ✅

Thank you for maintaining this project! Typo fix, looks good to me.

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Promotion: LGTM, ready to merge. Thanks for maintaining bert4torch! 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Bump 🙏

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Thank you for maintaining this project! Just a gentle nudge — happy to help with anything if review comments need clarification.

1 similar comment
@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Thank you for maintaining this project! Just a gentle nudge — happy to help with anything if review comments need clarification.

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Thank you for this PR! Just checking in - happy to address any feedback or make changes. Would love to help get this merged! 😊

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

👍 merge_promotion R309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant