Skip to content

fix: improve handling of NaN values in evaluation metrics calculation! #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amindadgar merged 1 commit into from
Oct 12, 2025
Merged

fix: improve handling of NaN values in evaluation metrics calculation! #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/evaluation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,13 @@ jobs:
df = pd.read_csv(results_csv)

metrics = ['faithfulness','answer_relevancy','context_precision','context_recall','factual_correctness(mode=f1)']
avgs = {m: float(df[m].mean()) for m in metrics if m in df.columns}
avgs = {}
for m in metrics:
if m in df.columns:
# Handle NaN values by using dropna() before calculating mean
mean_val = df[m].dropna().mean()
if pd.notna(mean_val): # Only add if the mean is not NaN
avgs[m] = float(mean_val)

cost_payload = {}
if cost_json.exists():
Expand Down