fix: show first divergent event with surrounding context in compare c…#560
Merged
Timi16 merged 1 commit intoTimi16:mainfrom Mar 25, 2026
Merged
fix: show first divergent event with surrounding context in compare c…#560Timi16 merged 1 commit intoTimi16:mainfrom
Timi16 merged 1 commit intoTimi16:mainfrom
Conversation
|
@AbuJulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
Enhanced the compare command in the soroban-debugger CLI to provide more actionable debugging information when execution traces diverge.
✨ Changes
🧠 LCS-Based Diffing: Switched to the Longest Common Subsequence (LCS) algorithm for more stable and accurate comparison of execution traces.
🖥️ First Divergence Monitoring: Automatically identifies and highlights the first point where traces depart.
🔍 Context Window: Added a --context (alias -C) flag to show surrounding unchanged events (default is 3).
🛠️ Codebase Maintenance: Harmonized field names (depth) and types (Option) across the analyzer, executor, and server modules.
🧪 Verification
Verified with 76 passing integration tests and new unit tests in src/compare/engine.rs.
Confirmed a clean build across the entire workspace.