You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request adds support for ignoring sfic fields and paths when comparing execution traces, making it easier to filter out noisy or irrelevant differences (such as timestamps or sequence numbers) in reports. It introduces new CLI options, updates the documentation, and refactors the comparison engine to apply these filters throughout the comparison process.
New filtering capabilities:
Added --ignore-field and --ignore-path options to the CLI, allowing users to exclude specific fields or JSON paths from the comparison (src/cli/args.rs, src/cli/commands.rs). [1][2]
Updated documentation to describe the new ignore filters, including usage examples and explanations of how they affect the comparison (docs/doc/compare.md). [1][2][3]
Comparison engine refactor:
Introduced a CompareFilters struct and integrated it into all major comparison functions, so storage, budget, return values, call sequences, and events are normalized according to the provided filters (src/compare/engine.rs). [1][2][3][4][5][6][7][8]
Diff output and reporting:
Modified the diff output for call sequences and events to show filtered results, ensuring that the report only reflects meaningful differences after applying ignore filters (src/compare/engine.rs). [1][2][3]
These changes make the comparison tool more robust and flexible, especially for use cases where certain fields or subtrees are expected to change and should not trigger false positives in regression tests.
This pull request adds support for ignoring sfic fields and paths when comparing execution traces, making it easier to filter out noisy or irrelevant differences (such as timestamps or sequence numbers) in reports. It introduces new CLI options, updates the documentation, and refactors the comparison engine to apply these filters throughout the comparison process.
New filtering capabilities:
Added --ignore-field and --ignore-path options to the CLI, allowing users to exclude specific fields or JSON paths from the comparison (src/cli/args.rs, src/cli/commands.rs). [1][2]
Updated documentation to describe the new ignore filters, including usage examples and explanations of how they affect the comparison (docs/doc/compare.md). [1][2][3]
Comparison engine refactor:
Introduced a CompareFilters struct and integrated it into all major comparison functions, so storage, budget, return values, call sequences, and events are normalized according to the provided filters (src/compare/engine.rs). [1][2][3][4][5][6][7][8]
Diff output and reporting:
Modified the diff output for call sequences and events to show filtered results, ensuring that the report only reflects meaningful differences after applying ignore filters (src/compare/engine.rs). [1][2][3]
These changes make the comparison tool more robust and flexible, especially for use cases where certain fields or subtrees are expected to change and should not trigger false positives in regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ignoring sfic fields and paths when comparing execution traces, making it easier to filter out noisy or irrelevant differences (such as timestamps or sequence numbers) in reports. It introduces new CLI options, updates the documentation, and refactors the comparison engine to apply these filters throughout the comparison process.
New filtering capabilities:
--ignore-fieldand--ignore-pathoptions to the CLI, allowing users to exclude specific fields or JSON paths from the comparison (src/cli/args.rs,src/cli/commands.rs). [1] [2]docs/doc/compare.md). [1] [2] [3]Comparison engine refactor:
CompareFiltersstruct and integrated it into all major comparison functions, so storage, budget, return values, call sequences, and events are normalized according to the provided filters (src/compare/engine.rs). [1] [2] [3] [4] [5] [6] [7] [8]Diff output and reporting:
src/compare/engine.rs). [1] [2] [3]These changes make the comparison tool more robust and flexible, especially for use cases where certain fields or subtrees are expected to change and should not trigger false positives in regression tests.
Closes #509