Fix for the blur effect when the direction is set to .right and .up (reversed)#21
Open
alpennec wants to merge 1 commit intoTimOliver:mainfrom
Open
Fix for the blur effect when the direction is set to .right and .up (reversed)#21alpennec wants to merge 1 commit intoTimOliver:mainfrom
alpennec wants to merge 1 commit intoTimOliver:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @TimOliver,
When using
blurStartingInsetfor my blurs, I noticed an issue in your library when using the.rightand.updirections for the blur.The blur doesn't seem correct for the
.rightand.updirections as you can see on this video using the original code:BlurUIKit_bug_720.mov
Here is another video with the code from this PR that fixes the issue:
BlurUIKit_fix_720.mov
Regards,
Axel
PS: please find below the SwiftUI code I used for the preview (not included in this PR).