Add support for dashes in filenames to test context extractor #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @swaldhoer, I think these might be different issues. This issue affects the include directive whereas issue #780 only affects test filenames. For example, I spotted this when a mock wasn't being generated for a file which included dashes in the name, but I think it affects more than just mock generation. |
|
Ah sorry yes I think you are correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like commit #b75b523 may have inadvertently broken support for dashes in filenames. A small change to the regex pattern in _extract_includes() fixes the issue.
I haven't found any open issues or anything to suggest support was dropped (Issue #439 suggests it was supported in release 1.0.0). Let me know if I've missed something.
I've tweaked an existing unit test to cover dashes in filenames.