[WIP] Update to Elm 0.18 and Firebase 3#16
Open
ThomasWeiser wants to merge 23 commits into
Open
Conversation
to avoid confusion with `subscription`
Simplifications: * Only subscription to valueChanged events * No query options * Fixed Firebase location
Unfortunately we cannot use a union type for Location as we did before. The implementation of the effect manager demands Location to be a comparable type. Union types are not comparable (in Elm 0.17). Lists and tuples are the only aggregate types that transports comparability of its element type.
As suggested by Rogério Chaves: #15 (comment) Pros: - No need to patch Firebase script - Faster loading from CDN / cache / parallel chunk. - Can upgrade firebase for non-breaking changes without changing ElmFire. - More flexibility while developing new ElmFire version Cons: - ElmFire is not self-contained any more. - User is now responsibly for compatibility of the version of included firebase.js script. This is a preliminary change during development. We may change back to included Firebase script for published versions of ElmFire. Needs to be discussed with community.
This was referenced Mar 24, 2017
Closed
Closed
|
Really like what I see happening now. |
Owner
Author
|
@atlewee thanks, missed that one. Example is now updated too. |
|
Hi @ThomasWeiser, I'm really interested in this project and I would like to help you to update it to Elm 0.18 but I'm not that advanced in Elm so if you're willing to somehow guide me I can help you with the code. To give you an idea of how I'm using Elm you can check the repos below (most recent to older)
Kind regards. |
|
FWIW, Firebase 4.x is out already (see release notes). Just saying in case you think it makes sense to sync directly to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to track progress. Please use it for discussions and reviews.
Previous discussions in issues Support elm 0.17 and Firebase 3.0
Agenda:
And: