Screen Reader Accessibility by jpdevries · Pull Request #5 · Thinkful-Ed/shopping-list

jpdevries · 2016-11-12T00:46:55Z

Closes #4

Adds a semantic heading structure making the app navigable by the VoiceOver rotor

Semantic form elements provide implicit accessibility by being navigable by the rotor as well.

Wraps the list section of the app in a form to encourage progressive enhancement.

The previous check and delete button weren't semantic or accessible. An <input type=checkbox> is the semantic way to toggle something like completion and should be used even if you opt to use CSS to hide the checkbox visually. An example of this would be Makeanico which uses a <input type=checkbox> for each cell of the art board.

Rather than a delete button, in the spirit of progressive enhancement checkboxes are used for the delete feature. The idea is that if JS breaks you check the items you want to delete and click the submit or trash deleted items button, it hit the server, and does so. Even if JS works, this is a nice features because it allows the user to undo an accidental deletion without having to ask for confirmation each time.

Uses the .visually-hidden pattern from a11y-project to hide elements visually but keep them available to screen readers. This is useful so the delete items read "delete milk" rather than just "delete".
http://a11yproject.com/posts/how-to-hide-content/

Uses the :target pseudo selector so for really long lists you can add #walnuts to the end of the URL and scroll half way down the list to that item to find that item highlighted.

Srikethrough complete styles do not depend on JavaScript (notice milk is initially checked semantically with <input checked>).

jpdevries · 2016-11-12T00:51:30Z

If this is merged I can submit a PR to Thinkful-Ed/shopping-list-solution also

Closes Thinkful-Ed#4 formatting CSS no-js friendly strikethrough feature Making milk checked initially

mxmason · 2017-02-02T04:47:05Z

index.html

-    </ul>
+    <form id="js-shopping-list-form">
+      <ul class="shopping-list">
+        <li id="apples">


Would a data-* attribute not be a better way to name each list item?

I feel like it would be if we didn't need unique IDs later for the form elements. Given this need, it's a good idea to use underscores to indicate states, etc., but I wanted to bring this up. Thoughts?

@dengeist I think the advantage of using an ID is they double as a hash jump to link to scroll to and :target that element. In other words, the id attribute isn't just for CSS

The underlying issue here is that we don't want to lock the student into a given way of managing the state for this. If we have state being stored in ids or in data attributes in the template, they're just going to use that approach when they create their app.

@jpdevries can you please explain the reasoning behind the ids?

Good point about offering too many opinions, @benjaminEwhite, but isn't this also a good time to teach the data-*attribute? This is a great use-case for it.

@benjaminEwhite the id isn't for managing state. it's for accessible jump-to :target links Uses the :target pseudo selector so for really long lists you can add #walnuts to the end of the URL and scroll half way down the list to that item to find that item highlighted.

Uses the :target pseudo selector so for really long lists you can add #walnuts to the end of the URL and scroll half way down the list to that item to find that item highlighted.

Oh that's nifty.

benjaminEwhite · 2017-02-06T21:36:39Z

index.html


-    <form id="js-shopping-list-form">
-      <label for="shopping-list-entry">Add an item</label>
+    <form id="js-shopping-list-add-item">


The js- prefix is reserved for ids and classes that are to be targeted by JS layer. Shouldn't be used for CSS. The one that's in master right now should actually be gone altogether, so if you need an id here for CSS, can create new one.

@benjaminEwhite just loosened the CSS selector to not reference the js id

benjaminEwhite · 2017-02-06T21:43:20Z

index.html

-    </ul>
+    <form id="js-shopping-list-form">
+      <ul class="shopping-list">
+        <li id="apples">


The underlying issue here is that we don't want to lock the student into a given way of managing the state for this. If we have state being stored in ids or in data attributes in the template, they're just going to use that approach when they create their app.

@jpdevries can you please explain the reasoning behind the ids?

benjaminEwhite · 2017-02-06T21:45:05Z

main.css

  width: 250px;
 }

+#js-shopping-list-add-item h2 {


see note above about js- prefix.

benjaminEwhite · 2017-02-06T21:45:41Z

main.css

 }

-.shopping-item__checked {
+input[type="checkbox"]:checked + label {


@benjaminEwhite

@benjaminEwhite loosened the selector

benjaminEwhite · 2017-02-07T15:53:59Z

What happens when you have multiple of same item on list and end up with doubled id values?

benjaminEwhite · 2017-02-07T16:31:47Z

@jpdevries finally grokked what this is doing. cool stuff.

So, in short term, not ready to merge this for v6 of FEWD because we need additional, earlier content in curriculum to establish the whys/hows of using targets + ids for creating navigable UIs.

In medium term, i think that this is the right way to go directionally. I've started designing FEWD v7, and a11y/progressive enhancement are must have features. Seems to me that we could add a reading to Unit 1 Lesson 6 that focuses on creating interactive UIs with just HTML and CSS. The lesson could be tweaked a bit so it's "Basic user interfaces". It would still teach forms as it does now, but we'd go deeper and explore some of the ways you can create robust interfaces without JS.

jpdevries · 2017-02-09T18:18:48Z

What happens when you have multiple of same item on list and end up with doubled id values?

ids have to be unique so sometimes I'll append the items unique id so something like walnut__5

jpdevries · 2017-02-09T21:47:20Z

@benjaminEwhite

So, in short term, not ready to merge this for v6 of FEWD because we need additional, earlier content in curriculum to establish the whys/hows of using targets + ids for creating navigable UIs.

If it would be helpful to pull the targets + ids stuff out for now I can. Otherwise I'll assume we'll hold off for FEWD 7.

jpdevries mentioned this pull request Nov 12, 2016

Not Accessible to Screen Readers Thinkful-Ed/shopping-list-solution#2

Open

jpdevries force-pushed the screen-reader branch from 80bade9 to 746cacc Compare November 12, 2016 01:13

Screen Reader Accessibility

b3892c2

Closes Thinkful-Ed#4 formatting CSS no-js friendly strikethrough feature Making milk checked initially

jpdevries force-pushed the screen-reader branch from 746cacc to b3892c2 Compare November 12, 2016 01:24

mxmason reviewed Feb 2, 2017

View reviewed changes

benjaminEwhite reviewed Feb 6, 2017

View reviewed changes

removing #js-shopping-list-add-item from CSS

c34522d

@benjaminEwhite loosened the selector

Conversation

jpdevries commented Nov 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpdevries commented Nov 12, 2016

Uh oh!

mxmason Feb 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpdevries Feb 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benjaminEwhite commented Feb 7, 2017

Uh oh!

benjaminEwhite commented Feb 7, 2017

Uh oh!

jpdevries commented Feb 9, 2017

Uh oh!

jpdevries commented Feb 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jpdevries commented Nov 12, 2016 •

edited

Loading

mxmason Feb 2, 2017 •

edited

Loading

jpdevries Feb 6, 2017 •

edited

Loading